Avoid using shared cache for internally stored files #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
+ Coverage 75.68% 75.70% +0.01%
==========================================
Files 94 94
Lines 14701 14727 +26
==========================================
+ Hits 11127 11149 +22
- Misses 3574 3578 +4 |
loewenheim
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit wasteful to look up our internally hosted Symbols on GCS, just to store them on GCS again in the form of the shared cache.
We can avoid doing this needless duplication of roundtrips and storage.
We could also avoid using the shared cache for objects and bundle indexes that are stored in Sentry, but here the benefits are less clear, as avoiding shared cache would mean going through the Python abstraction. Right now, we rather waste a bit of storage in favor of avoiding Python.
These tradeoffs could potentially change in the future with a more efficient filestore implementation though.
#skip-changelog